Skip to content

Conversation

@yanghua
Copy link
Contributor

@yanghua yanghua commented Apr 15, 2019

What is the purpose of the change

This pull request fixes IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot

Brief change log

  • Fix IllegalArgumentException throwed by FlinkKinesisConsumerMigrationTest#writeSnapshot

Verifying this change

This change is already verified by commits 86e33fe36ed29b6e01dd7fe4151a8650ad25612c in PR #8168 *.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@yanghua yanghua changed the title [FLINK-12190] Fix IllegalArgumentException throwed by FlinkKinesisConsumerMigrationTest#writeSnapshot [FLINK-12190] Fix IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot Apr 15, 2019
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@yanghua
Copy link
Contributor Author

yanghua commented Apr 15, 2019

@tzulitai The Travis is failed because of Kafka connector IT test case, I have reported an issue: FLINK-12196.

@zentol
Copy link
Contributor

zentol commented Apr 18, 2019

Please expand the description. It should explain what the underlying problem is and how your solutio addresses it.

@yanghua
Copy link
Contributor Author

yanghua commented Apr 18, 2019

@zentol Sorry, I have added more details. It is because the exists code did not initialize TestFetcher correctly. Actually, there is a discussion in FLINK-10785. I have discussed with @tzulitai about the solution before.

@yanghua
Copy link
Contributor Author

yanghua commented May 7, 2019

@tzulitai Can you review this PR? thanks.

@yanghua
Copy link
Contributor Author

yanghua commented Jun 3, 2019

@tzulitai I think this PR can make sense for someone who wants to do the migration test after releasing Flink 1.9. If you have time, can you review this PR? thanks.

@tzulitai tzulitai self-requested a review June 3, 2019 04:57
@tzulitai
Copy link
Contributor

tzulitai commented Jun 3, 2019

Sorry for the late review on this one. LGTM, +1.
Merging ..

tzulitai pushed a commit to tzulitai/flink that referenced this pull request Jun 3, 2019
@yanghua
Copy link
Contributor Author

yanghua commented Jun 20, 2019

Hi @tzulitai I think this PR can also be merged. WDYT?

@tzulitai
Copy link
Contributor

Merging ...

@asfgit asfgit closed this in f9681c0 Jun 26, 2019
zentol pushed a commit to zentol/flink that referenced this pull request Jun 26, 2019
…nesisConsumerMigrationTest#writeSnapshot

This closes apache#8174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants