-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-12190] Fix IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot #8174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sumerMigrationTest#writeSnapshot
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
@tzulitai The Travis is failed because of Kafka connector IT test case, I have reported an issue: FLINK-12196. |
|
Please expand the description. It should explain what the underlying problem is and how your solutio addresses it. |
|
@zentol Sorry, I have added more details. It is because the exists code did not initialize |
|
@tzulitai Can you review this PR? thanks. |
|
@tzulitai I think this PR can make sense for someone who wants to do the migration test after releasing Flink 1.9. If you have time, can you review this PR? thanks. |
|
Sorry for the late review on this one. LGTM, +1. |
…sumerMigrationTest#writeSnapshot This closes apache#8174.
|
Hi @tzulitai I think this PR can also be merged. WDYT? |
|
Merging ... |
…nesisConsumerMigrationTest#writeSnapshot This closes apache#8174.
What is the purpose of the change
This pull request fixes IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot
Brief change log
Verifying this change
This change is already verified by commits 86e33fe36ed29b6e01dd7fe4151a8650ad25612c in PR #8168 *.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation