Skip to content

Comments

[FLINK-12230][runtime] Remove method JobMaster#getExecutionGraph()#8211

Closed
GJL wants to merge 1 commit intoapache:masterfrom
GJL:FLINK-12230
Closed

[FLINK-12230][runtime] Remove method JobMaster#getExecutionGraph()#8211
GJL wants to merge 1 commit intoapache:masterfrom
GJL:FLINK-12230

Conversation

@GJL
Copy link
Member

@GJL GJL commented Apr 18, 2019

What is the purpose of the change

Remove method JobMaster#getExecutionGraph(). This is needed because the JobMaster will not have access to the ExecutionGraph in future

Brief change log

  • Remove method JobMaster#getExecutionGraph()

Verifying this change

This change is already covered by existing tests, such as JobMasterTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 18, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this fix @GJL. LGTM. +1 for merging.

@tillrohrmann tillrohrmann self-assigned this Apr 24, 2019
@tillrohrmann
Copy link
Contributor

@flinkbot approve all

@GJL
Copy link
Member Author

GJL commented Apr 26, 2019

Thanks for the review. I rebased to latest master and will merge as soon as build is green.

@asfgit asfgit closed this in 8a8d722 Apr 28, 2019
tianchen92 pushed a commit to tianchen92/flink that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants