[FLINK-12230][runtime] Remove method JobMaster#getExecutionGraph()#8211
Closed
GJL wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-12230][runtime] Remove method JobMaster#getExecutionGraph()#8211GJL wants to merge 1 commit intoapache:masterfrom
GJL wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
tillrohrmann
approved these changes
Apr 24, 2019
Contributor
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for providing this fix @GJL. LGTM. +1 for merging.
Contributor
|
@flinkbot approve all |
Member
Author
|
Thanks for the review. I rebased to latest master and will merge as soon as build is green. |
tianchen92
pushed a commit
to tianchen92/flink
that referenced
this pull request
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove method
JobMaster#getExecutionGraph(). This is needed because theJobMasterwill not have access to theExecutionGraphin futureBrief change log
JobMaster#getExecutionGraph()Verifying this change
This change is already covered by existing tests, such as JobMasterTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation