Skip to content

[FLINK-9904]Allow users to control MaxDirectMemorySize#8223

Closed
tianchen92 wants to merge 4 commits intoapache:masterfrom
tianchen92:FLINK-9904
Closed

[FLINK-9904]Allow users to control MaxDirectMemorySize#8223
tianchen92 wants to merge 4 commits intoapache:masterfrom
tianchen92:FLINK-9904

Conversation

@tianchen92
Copy link
Contributor

What is the purpose of the change

This PR is related to FLINK-9904. Make MaxDirectMemorySize configurable via flink-conf.yaml.

Brief change log

  • Make MaxDirectMemorySize configurable.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (don't know)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@tianchen92
Copy link
Contributor Author

@tillrohrmann hi, could you please help review this PR? thanks!

@tianchen92 tianchen92 closed this Apr 23, 2019
@tianchen92 tianchen92 reopened this Apr 23, 2019
@tianchen92 tianchen92 closed this Apr 23, 2019
@tianchen92 tianchen92 reopened this Apr 23, 2019
@klion26
Copy link
Member

klion26 commented Apr 25, 2019

@tianchen92 thanks for your contribution, Could you please clear the last merge commit? you can use git rebase.

@tianchen92 tianchen92 closed this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments