Skip to content

Conversation

@leesf
Copy link
Contributor

@leesf leesf commented Apr 19, 2019

What is the purpose of the change

Port ExecutionGraphRestartTest to new codebase.

Brief change log

(for example:)

  • Use TaskManagerLocation, SimpleAckingTaskManagerGateway and TestingResourceManagerGateway in repalce of Instance.
  • *Use SlotPool#releaseTaskManager in replace of Instrance#markDead *

Verifying this change

This change is a trivial rework.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@tillrohrmann
Copy link
Contributor

Thanks for opening this PR @leesf. Could you please rebase against the current master to resolve the merge conflicts?

@leesf
Copy link
Contributor Author

leesf commented Apr 27, 2019

@tillrohrmann Rebased.

Copy link
Contributor

@azagrebin azagrebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR @leesf !
I have left some review comments.

new SimpleAckingTaskManagerGateway(),
NUM_TASKS);
private ExecutionGraph createExecutionGraph(RestartStrategy restartStrategy, SlotPool slotPool) throws Exception {
setupSlotPool(slotPool, resourceManagerGateway, mainThreadExecutor);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beginning of createExecutionGraph looks like the same as just calling createSchedulerWithSlots(NUM_TASKS, taskManagerGateway, slotPool).

this.jobId = new JobID();

taskManagerLocation = new LocalTaskManagerLocation();
taskManagerGateway = new SimpleAckingTaskManagerGateway();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these variables created globally? They could be created and used only in private graph/scheduler creation methods after some code deduplication.

Also taskManagerGateway is created again locally in some tests: testLocalFailAndRestart, testRestartWithEagerSchedulingAndSlotSharing, testRestartWithSlotSharingAndNotEnoughResources which might not be needed.

public void testFailWhileRestarting() throws Exception {
Scheduler scheduler = new Scheduler(TestingUtils.defaultExecutionContext());
try (SlotPool slotPool = new SlotPoolImpl(jobId)) {
setupSlotPool(slotPool, resourceManagerGateway, mainThreadExecutor);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beginning looks like just calling createExecutionGraph with custom JobGraph. If createExecutionGraph accepted JobGraph, this code could be deduplicated.
The same for other tests with similar code duplication.

@leesf
Copy link
Contributor Author

leesf commented May 7, 2019

@azagrebin Thanks for you review and sorry for lately reply. Updated the PR and address your comments, would you please review this pr in your free time? cc @tillrohrmann

@azagrebin
Copy link
Contributor

Thanks for addressing the comments @leesf !
I created another PR with some more refactoring #8386 on top of this PR.
Please, have a look if you agree, we can close this PR and I will squash our commits into a co-authored one in my PR to merge.
I also included changes from #7809 to port SimpleSlotProvider used in ExecutionGraphRestartTest.

@leesf
Copy link
Contributor Author

leesf commented May 20, 2019

@azagrebin Thanks for opening another PR, I will close this one.

@leesf leesf closed this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants