Skip to content

Comments

[FLINK-12322] Remove legacy ActorTaskManagerGateway#8255

Closed
tillrohrmann wants to merge 2 commits intoapache:masterfrom
tillrohrmann:removeActorTaskManagerGateway
Closed

[FLINK-12322] Remove legacy ActorTaskManagerGateway#8255
tillrohrmann wants to merge 2 commits intoapache:masterfrom
tillrohrmann:removeActorTaskManagerGateway

Conversation

@tillrohrmann
Copy link
Contributor

What is the purpose of the change

Remove legacy ActorTaskManagerGateway

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Remove ActorTaskManagerGateway from InstanceManagerTest

Remove ActorTaskManagerGateway from ExecutionGraphRestartTest

Remove ActorTaskManagerGateway from ExecutionVertexCancelTest

Remove ActorTaskManagerGateway from InstanceTest

Remove ActorTaskManagerGateway from SimpleSlotTest

Remove ActorTaskManagerGateway
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 24, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flinkbot approve all

@asfgit asfgit closed this in fdc32cd Apr 25, 2019
@tillrohrmann tillrohrmann deleted the removeActorTaskManagerGateway branch April 25, 2019 06:38
tianchen92 pushed a commit to tianchen92/flink that referenced this pull request May 13, 2019
Remove ActorTaskManagerGateway from InstanceManagerTest

Remove ActorTaskManagerGateway from ExecutionGraphRestartTest

Remove ActorTaskManagerGateway from ExecutionVertexCancelTest

Remove ActorTaskManagerGateway from InstanceTest

Remove ActorTaskManagerGateway from SimpleSlotTest

Remove ActorTaskManagerGateway

This closes apache#8255.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants