-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[hotfix][yarn] userJarFiles can be a local variable #8264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
tillrohrmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @tisonkun. I'll address my comment while merging this PR.
| userJarFiles.add(new File(path.toUri())); | ||
| } | ||
| } | ||
| final List<File> userJarFiles = (jobGraph == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's deduplicate entries by using a Set here.
|
@tillrohrmann thanks for your review! I accidentally added a force push on this pr. Sorry and please check if conflict :( |
|
No problem. Merging now. |
What is the purpose of the change
Variable
AbstractYarnClusterDescriptor#userJarFilescan be a local variable. Localize it for readability and possible further improvement.Corresponding discussion can be found at a954ea1#commitcomment-33276875
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
cc @tillrohrmann @zentol