Skip to content

[FLINK-12339][example] Fix variable name#8284

Merged
zentol merged 2 commits intoapache:masterfrom
mjl18758265781:FLINK-12339
Apr 27, 2019
Merged

[FLINK-12339][example] Fix variable name#8284
zentol merged 2 commits intoapache:masterfrom
mjl18758265781:FLINK-12339

Conversation

@mjl18758265781
Copy link
Contributor

What is the purpose of the change

This pull request rename topSeed to topSpeed in TopSpeedWindowing.scala. This variable is correct in this TopSpeedWindowing.java

Verifying this change

(Please pick either of the following options)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): (no =)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@mjl18758265781 mjl18758265781 changed the title Flink 12339 [Flink 12339][Example]Modify the wrong variable name of topSeed in example Apr 26, 2019
@zentol zentol changed the title [Flink 12339][Example]Modify the wrong variable name of topSeed in example [FLINK-12339][example] Fix variable name Apr 27, 2019
@zentol zentol merged commit f3161bd into apache:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants