Skip to content

Conversation

@robstoll
Copy link
Contributor

@robstoll robstoll commented May 6, 2019

What is the purpose of the change

improve documentation

Brief change log

I am new to flink so maybe I misunderstood something. As far as I am get Avro is only used if the POJO comes from a source which was deserialised with Avro. Otherwise Kryo is used. Thus I changed the text, mentioning Kryo as well and added a link to the Serialization of POJO types section (I guess the link to the other page makes sense in all cases).

Verifying this change

  • This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? => no

@flinkbot
Copy link
Collaborator

flinkbot commented May 6, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@StephanEwen
Copy link
Contributor

Oh wow, the docs here are really outdated and wrong.

The correct way would be as follows:

POJOs are generally represented with a PojoTypeInfo and serialized with the PojoSerializer (using Kryo as a configurable fallback).

The exception is when the POJOs are actually Avro types (Avro Specific Records) or produced as "Avro Reflect Types". In that case the POJO's type would be represented by an AvroTypeInformation and use the AvroSerializer.

@StephanEwen
Copy link
Contributor

Do you want to update the PR with this extra information?

@robstoll
Copy link
Contributor Author

I'll will in the next days

@robstoll
Copy link
Contributor Author

@StephanEwen I tried to integrate your information into my PR

@zentol zentol self-assigned this May 16, 2019
@robstoll
Copy link
Contributor Author

@zentol fixed https and reverted KryoSerializer

@zentol zentol merged commit 2937b60 into apache:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants