Skip to content

Conversation

@sjwiesman
Copy link
Contributor

What is the purpose of the change

Most documentation writers are only ever focused on one language at a time. Adding language-specific build flags can dramatically reduce render time during local development.

We add two new flags to the build script
-e: Only build English documentation
-z: Only build Chinese documentation

Verifying this change

Benchmarking on a MacBook Pro

Full clean builds

./build.sh: 176 seconds
./build.sh -e: 96 seconds
./build.sh -z: 62 seconds

Incremental Builds after changing one file
./build.sh -pi : 6.2 seconds
./build.sh -pie : 3.1 seconds

@sjwiesman
Copy link
Contributor Author

cc @fhueske @wuchong

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@wuchong
Copy link
Member

wuchong commented May 20, 2019

Thanks @sjwiesman , it's a great idea. Could you also add some instruction to docs/README.md ?

@sjwiesman
Copy link
Contributor Author

@wuchong good call

@wuchong
Copy link
Member

wuchong commented May 21, 2019

Thanks @sjwiesman , looks good to me and I get the same build time in my local machine.

Will merge this.

@asfgit asfgit closed this in 5c5342e May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants