[FLINK-12705][hive] Allow user to specify the Hive version in use #8694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Contributor
Author
|
cc @bowenli86 @xuefuz @zjuwangg please take a look, thanks. |
bowenli86
reviewed
Jun 12, 2019
...nnector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableOutputFormat.java
Outdated
Show resolved
Hide resolved
...tors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
Show resolved
Hide resolved
...ive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveMetastoreClientWrapper.java
Show resolved
Hide resolved
...-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimLoader.java
Outdated
Show resolved
Hide resolved
...ive/src/main/java/org/apache/flink/table/catalog/hive/descriptors/HiveCatalogDescriptor.java
Show resolved
Hide resolved
...l-client/src/test/java/org/apache/flink/table/client/gateway/local/ExecutionContextTest.java
Outdated
Show resolved
Hide resolved
| return new HiveCatalog(catalogName, null, createHiveConf(), null); | ||
| } | ||
|
|
||
| public static HiveCatalog createHiveCatalog(String name, Map<String, String> properties) { |
Member
There was a problem hiding this comment.
minor: can we combine this util and the above one? We may have a bit too many utils to create a HiveCatalog :) BTW, I think it can just take a hive version and let callers decide and get whichever version it wants to use
lirui-apache
force-pushed
the
FLINK-12705
branch
from
2c5be2b to
5050a27
Compare
Contributor
Author
|
@bowenli86 thanks for your comments. Please take another look. |
bowenli86
reviewed
Jun 14, 2019
| super(catalogName, defaultDatabase == null ? DEFAULT_DB : defaultDatabase); | ||
|
|
||
| this.hiveConf = hiveConf == null ? createHiveConf(null) : hiveConf; | ||
| checkArgument(!StringUtils.isNullOrWhitespaceOnly(hiveVersion), "hiveVersion cannot be empty"); |
Member
There was a problem hiding this comment.
Suggested change
| checkArgument(!StringUtils.isNullOrWhitespaceOnly(hiveVersion), "hiveVersion cannot be empty"); | |
| checkArgument(!StringUtils.isNullOrWhitespaceOnly(hiveVersion), "hiveVersion cannot be null or empty"); |
| public HiveMetastoreClientWrapper(HiveConf hiveConf) { | ||
| public HiveMetastoreClientWrapper(HiveConf hiveConf, String hiveVersion) { | ||
| this.hiveConf = Preconditions.checkNotNull(hiveConf, "HiveConf cannot be null"); | ||
| checkArgument(!StringUtils.isNullOrWhitespaceOnly(hiveVersion), "hiveVersion cannot be empty"); |
Member
There was a problem hiding this comment.
Suggested change
| checkArgument(!StringUtils.isNullOrWhitespaceOnly(hiveVersion), "hiveVersion cannot be empty"); | |
| checkArgument(!StringUtils.isNullOrWhitespaceOnly(hiveVersion), "hiveVersion cannot be null or empty"); |
sjwiesman
pushed a commit
to sjwiesman/flink
that referenced
this pull request
Jun 26, 2019
This PR allows users to specify hive version in the yaml file. This closes apache#8694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To allow user to specify hive version in the yaml file.
Brief change log
HiveVersionInfo.Verifying this change
Added unit test.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation