Skip to content

Conversation

@ozancicek
Copy link
Contributor

What is the purpose of the change

Added support to ignore null fields when writing to c* for tuple types.

Brief change log

  • Added 'ignoreNullFields' config parameter which can be enabled
  • Unset nulls from bound statement.

Verifying this change

This change added tests and can be verified as follows:
Added a test case to CassandraConnectorITCase testing partial column updates

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 12, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@StephanEwen
Copy link
Contributor

@flinkbot approve-until architecture

@StephanEwen
Copy link
Contributor

Overall approach looks good.

I would ask you to switch to use primitive booleans rather than boxed booleans, to be consistent with the approach in the remainder of Flink. This also avoid accidental nullability and late null pointer exceptions.

Otherwise looks good to me.

@StephanEwen
Copy link
Contributor

@flinkbot approve all

@StephanEwen
Copy link
Contributor

Looks good to me, merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jul 3, 2019
@asfgit asfgit closed this in a125e2a Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants