-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-12820][Connectors / Cassandra] Support ignoring writing nulls #8714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
...a/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseConfig.java
Outdated
Show resolved
Hide resolved
|
@flinkbot approve-until architecture |
|
Overall approach looks good. I would ask you to switch to use primitive booleans rather than boxed booleans, to be consistent with the approach in the remainder of Flink. This also avoid accidental nullability and late null pointer exceptions. Otherwise looks good to me. |
|
@flinkbot approve all |
|
Looks good to me, merging this... |
… for tuple types This closes apache#8714
What is the purpose of the change
Added support to ignore null fields when writing to c* for tuple types.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Added a test case to CassandraConnectorITCase testing partial column updates
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation