Skip to content

Conversation

@ppotseluev
Copy link

What is the purpose of the change

It fixes problems when using flink with ipv6.

Brief change log

  • Fixed AkkaUtils.getRemoteAkkaConfig to work with ipv6 addresses in typesafe config.
  • Fixed NetUtils.unresolvedHostToNormalizedString to work with already normalized ipv6 addresses.

Verifying this change

Added test cases to AkkaUtilsTest and NetUtilsTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 13, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@rmetzger
Copy link
Contributor

Thanks a lot for this contribution. Flink has a very ambitious roadmap for the upcoming 1.9 release, that's why many committers are quite busy finishing up their work.
You might experience a little delay in the review of this change, but we'll still try to give you feedback as soon as possible.
Thanks again!

@StephanEwen
Copy link
Contributor

@flinkbot approve all

@StephanEwen
Copy link
Contributor

Thanks for reporting this. The fix looks good and correct, the tests make sense.

Will merge this...

@StephanEwen StephanEwen self-assigned this Jul 2, 2019
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jul 2, 2019
  - Fixes problems around akka configuration parsing with some IPv6 literals
  - Fixes an issue with address parsing and validation with some Ipv6 literals

This closes apache#8734
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jul 2, 2019
  - Fixes problems around akka configuration parsing with some IPv6 literals
  - Fixes an issue with address parsing and validation with some Ipv6 literals

This closes apache#8734
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jul 3, 2019
  - Fixes problems around akka configuration parsing with some IPv6 literals
  - Fixes an issue with address parsing and validation with some Ipv6 literals

This closes apache#8734
@asfgit asfgit closed this in 3854552 Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants