[FLINK-12743][table-runtime-blink] Introduce unbounded streaming anti/semi join operator #8792
Conversation
…/semi join operator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @wuchong , The changes looks good to me. I only left one question.
| } | ||
| collector.collect(other); | ||
| } // ignore when number > 0 | ||
| other.setHeader(BaseRowUtil.ACCUMULATE_MSG); |
There was a problem hiding this comment.
why set acc to other? Will it be used again?
There was a problem hiding this comment.
Header of other may be set to RETRACT before, so we have to set it back when storing it in state. All rows stored in state are all accumulate BaseRows.
I did a minor adjust for this to move this line close to setting retract header, and add a comment, to make it more readable.
| } | ||
| collector.collect(other); | ||
| } // ignore when number > 0 | ||
| other.setHeader(BaseRowUtil.ACCUMULATE_MSG); |
There was a problem hiding this comment.
same question as above.
|
LGTM +1 |
4 participants
What is the purpose of the change
This pull request supports unbounded streaming semi/anti join.
Brief change log
StreamingSemiAntiJoinOperatoroperator to support semi/anti joinAbstractStreamingJoinOperatorto put shared member fields and utility forStreamingSemiAntiJoinOperatorandStreamingJoinOperatorVerifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation