Skip to content

[hotfix] Fix error message in BatchTableSourceScan#8796

Merged
dawidwys merged 2 commits intoapache:masterfrom
sjwiesman:fixmsg
Jun 19, 2019
Merged

[hotfix] Fix error message in BatchTableSourceScan#8796
dawidwys merged 2 commits intoapache:masterfrom
sjwiesman:fixmsg

Conversation

@sjwiesman
Copy link
Contributor

What is the purpose of the change

Trivial fix so that the error message outputs the correct types.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

@sjwiesman
Copy link
Contributor Author

cc @dawidwys

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@dawidwys
Copy link
Contributor

Good catch @sjwiesman! Merging

@dawidwys dawidwys merged commit 02b676e into apache:master Jun 19, 2019
@sjwiesman sjwiesman deleted the fixmsg branch June 19, 2019 14:41
@sjwiesman sjwiesman restored the fixmsg branch August 8, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants