[FLINK-12918][table][hive] unify GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl

[bowenli86]

What is the purpose of the change

This PR unifies implementations of CatalogTable by combining GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl.

Brief change log

• combined GenericCatalogTable, HiveCatalogTable and AbstractCatalogTable into CatalogTableImpl
• moved IS_GENERIC flag from GenericInMemoryCatalog to CatalogConfig
• updated unit tests

Verifying this change

This change added tests and can be verified as follows: GenericInMemoryCatalogTest, HiveCatalogHiveMetadataTest, HiveCatalogGenericMetadataTest

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector:(no)

Documentation

• Does this pull request introduce a new feature? (yes)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[bowenli86]

cc @xuefuz @lirui-apache @zjuwangg

@sunjincheng121 @dianfu can you verify the python part?

[dianfu]

@bowenli86 Thanks a lot for the PR. The changes related to the Python part LGTM.

[xuefuz]

Since CatalogTable has multiple of subclasses, we probably need to make sure that the classes are equal too.

[xuefuz]

LGTM. Just one minor comment.

[bowenli86]

@xuefuz thanks for your review! I updated the PR

[bowenli86]

I rebased to master to resolve conflicts. @xuefuz can you take another look?

[xuefuz]

LGTM.

[xuefuz]

The newly added class, HiveTableFactory, still has reference to GenericCatalogTable. However, I don't see any changes included for that.

[bowenli86]

@xuefuz I just rebased this PR to master

[xuefuz]

+1

[bowenli86]

The assigned travis build probably won't finish 10 hours later. My private build succeeded .

Merging.