Skip to content

Conversation

@sunhaibotb
Copy link
Contributor

What is the purpose of the change

This pull request changes the processing that the input reaches the end to comply with the following InputSelectable contract.

  • When the input being read reaches the end, the runtime must call nextSelection() to determine the next input to be read.

Brief change log

  • Uses invoking InputSelectable#nextSelection() to replace the assignment on the input selection in StreamTwoInputSelectableProcessor#checkFinished() . The input selection should been switched in endInput() by the operator.

Verifying this change

This change is already covered by existing tests, such as StreamTaskSelectiveReadingTest, StreamTaskSelectiveReadingITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…he end to comply with the InputSelectable contract
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change. I will merge it with green travis :)

@sunhaibotb
Copy link
Contributor Author

sunhaibotb commented Jun 25, 2019

Thanks for the review. The travis is already green. @pnowojski

@pnowojski pnowojski merged commit 762ef72 into apache:master Jun 25, 2019
@sunhaibotb sunhaibotb deleted the FLINK-12967 branch June 25, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants