Skip to content

Conversation

@HuangXingBo
Copy link
Contributor

What is the purpose of the change

Fix wrong example code in Python REPL and wrong table plan in table/common page

Brief change log

  • Correct example code in python_shell.md/python_shell.zh.md
  • Correct table plan in common.md/common.zh.md

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2019

CI report for commit 8d45d83: FAILURE Build

@dianfu
Copy link
Contributor

dianfu commented Jul 9, 2019

@HuangXingBo Thanks a lot for the PR. The changes LGTM. +1 from my side.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 9, 2019

CI report for commit 59c41a2: FAILURE Build

@WeiZhong94
Copy link
Contributor

@HuangXingBo Thanks for your pull request! LGTM and +1 from my side.

@sunjincheng121 sunjincheng121 merged commit e4f4470 into apache:master Jul 9, 2019
@HuangXingBo HuangXingBo deleted the hotfix-doc branch July 9, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants