[FLINK-13157]reeanble unit test read complext type of HiveInputFormatTest

[zjuwangg]

What is the purpose of the change

reeanble unit test read complext type of HiveInputFormatTest

Brief change log

• reeanble unit test read complext type of HiveInputFormatTest

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no )
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[zjuwangg]

cc @bowenli86 @xuefuz @lirui-apache
Travis-LinkLink

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 688f581 (Fri Aug 23 10:13:53 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[bowenli86]

@zjuwangg thanks for your contribution!

I wonder if we should add a shim for the changes you made in HiveInspectors?

[flinkbot]

CI report for commit a25ebb2: FAILURE Build

[zjuwangg]

@zjuwangg thanks for your contribution!

I wonder if we should add a shim for the changes you made in HiveInspectors?

@bowenli86 I talked with @lirui-apache offline and found a way to make the change in HiveInspectors look more reasonable.
We don't need a shim for the changes right now, maybe it's needed for the long term.

[lirui-apache]

LGTM overall. Probably a follow up is to use hive runner to simplify these tests.

[flinkbot]

CI report for commit 8d6650f: SUCCESS Build

[zjuwangg]

address @lirui-apache 's comments.

[flinkbot]

CI report for commit 688f581: SUCCESS Build

[xuefuz]

The latest changes look good to me. It would be good if we can revert unnecessary changes on the indention. (This might be taken care at commit time.(

[bowenli86]

The latest changes look good to me. It would be good if we can revert unnecessary changes on the indention. (This might be taken care at commit time.(

Yes, as @xuefuz mentioned, please revert any unnecessary changes in the future. I reverted them for you this time.

Ran tests for Hive 2.3.4 and 1.2.1 locally. Merging

[zjuwangg]

The latest changes look good to me. It would be good if we can revert unnecessary changes to the indention. (This might be taken care at commit time. (

Yes, as @xuefuz mentioned, please revert any unnecessary changes in the future. I reverted them for you this time.

Ran tests for Hive 2.3.4 and 1.2.1 locally. Merging

Thanks, I will take care of in the future.