[FLINK-13173][tests] only run openSSL-based tests with flink.tests.with-openssl #9048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Rename
flink.tests.force-openssl(introduced for Flink 1.9) toflink.tests.with-openssland only run openSSL-based unit tests if this is set. This way, we avoid systems where the bundled dynamic libraries do not work. Travis seems to run fine and will have this property set.For examples of such scenarios and why (for now) we cannot rely on automatic openSSL detection, please refer to https://issues.apache.org/jira/browse/FLINK-13172.
Brief change log
flink.tests.force-openssltoflink.tests.with-opensslSSLUtilsTestto the inverse logic and provideSSLUtilsTest#AVAILABLE_SSL_PROVIDERSaccordinglyVerifying this change
I tested
SSLUtilsTestin all combinations of having openSSL (not) available and w/oflink.tests.with-opensslso that openSSL is picked up or the test is failing if it is not.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation