Skip to content

Conversation

@mrzhangboss
Copy link

What is the purpose of the change

fix spelling and code reference in flink-table/flink-sql-client

Brief change log

  • rename EXECUTION_CURRNET_DATABASE -> EXECUTION_CURRENT_DATABASE
  • rename EXECUTION_CURRNET_CATALOG -> EXECUTION_CURRENT_CATALOG
  • rename the code refernce in flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/entries/ExecutionEntry.java

Verifying this change

  • Already passed all the tests in flink-sql-client

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 10, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 457e3a2 (Wed Oct 16 13:44:58 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@AjaxXu AjaxXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flinkbot
Copy link
Collaborator

CI report for commit 4f893ac: SUCCESS Build

@mrzhangboss mrzhangboss force-pushed the fix-spelling-mistake-in-sql-client-fink-12182 branch from 4f893ac to 3d8aa4e Compare July 15, 2019 05:50
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 15, 2019

CI report:

…/flink-sql-client

fix spelling and code reference
@mrzhangboss mrzhangboss force-pushed the fix-spelling-mistake-in-sql-client-fink-12182 branch from 3d8aa4e to 457e3a2 Compare July 15, 2019 06:32
@aljoscha
Copy link
Contributor

This has been resolved as the side effect of another commit.

@aljoscha aljoscha closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants