-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-2359] [java api] Add factory methods to the Java TupleX types #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should we call it |
|
I also prefer |
|
Thanks for adding the generator methods. That's definitely more convenient than using |
|
Ok, of looks better indeed. I will modify it. |
|
PR looks good to me except for the purely reformatting changes which should be excluded from the PR. |
|
@fhueske: |
|
Ah OK. It's fine to commit the changes if they are caused by the TupleGenerator. |
|
I'm going to merge this PR |
Clean up dependencies by centralizing most of the ML function code in it's own module. Also organizes files into a package structure. Functions, Runtimes, and MLFunctionsModule were left where they were for now. The below list of Classes/References did NOT move packages as they are imported in metastore/sql-service, so this change should be backwards/forwards compatible from the standpoint of downstream dependencies: MLModelCommonConstants MLModelCommonConstants.ModelKind MLModelCommonConstants.ModelTask RemoteModelOptions.EncryptionStrategy RemoteModelValidator MLEvaluateFunction MLPredictFunction MLModelRuntime Follow-on work: 1) Get MLModelRuntime.validateSchemas to be callable from RemoteModelValidator. 2) move everything referenced by downstream dependencies to a single place.
I added the creation of the factory method to the TupleGenerator.
I also fixed some inconsistencies between the generator and generated files: it seems that some modifications were made to generated files without modifying the generator. I incorporated these changes to the generator (see the first three hunks in the generator) (except for some whitespace changes in the first three modified files).
I randomly changed some constructor calls into using the new method for testing and demonstration purposes (see the last two changed files).