-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[hotfix][connector] fix typo in filters of maven shade plguin #9142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 176b9fe (Tue Aug 06 15:43:59 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
I check maven plugin code and did some experiments. The conclusion is that Maven maps plugin configuration in xml to a Mojo(by @parameter annotation). And when the mojo has an array parameter( in this case), maven do not check the sub-tag of that parameter. |
|
That's why the typo exclude works. |
|
Thanks for the explanation @docete . Looks good to me. Btw, do you intend to merge this to 1.9? |
Yes, should i create another PR for 1.9? |
|
@docete , not needed. I will cherry pick to 1.9. |
|
@wuchong OK, Thanks. |
What is the purpose of the change
Fix typo in filters of maven shade plugin.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation