-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-13397] Remove RollingSink #9214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will have a look @aljoscha |
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 76b9f95 (Tue Aug 06 15:50:39 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
kl0u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @aljoscha.
There are places where the "rolling sink" has not been removed, like the guarantees.md and the sidebar in the documentation, under the tab connectors.
|
Thanks for the review! I pushed the required changes. PTAL. |
kl0u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @aljoscha !
+1 to merge
|
Thanks for the review! I merged |
What is the purpose of the change
This has been superseded by the BucketingSink and has been deprecated for some releases now.
Brief change log
Verifying this change