Skip to content

Conversation

@aljoscha
Copy link
Contributor

What is the purpose of the change

This has been superseded by the BucketingSink and has been deprecated for some releases now.

Brief change log

  • Remove RollingSink and associated classes
  • Update figure in documentation

Verifying this change

  • Nothing to verify, this only removes code

@aljoscha aljoscha requested a review from kl0u July 24, 2019 09:15
@kl0u
Copy link
Contributor

kl0u commented Jul 24, 2019

I will have a look @aljoscha

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 24, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 76b9f95 (Tue Aug 06 15:50:39 UTC 2019)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 24, 2019

CI report:

Copy link
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @aljoscha.

There are places where the "rolling sink" has not been removed, like the guarantees.md and the sidebar in the documentation, under the tab connectors.

@aljoscha
Copy link
Contributor Author

Thanks for the review! I pushed the required changes. PTAL.

Copy link
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @aljoscha !
+1 to merge

@aljoscha aljoscha closed this Jul 25, 2019
@aljoscha aljoscha deleted the remove-rolling-sink branch July 25, 2019 15:06
@aljoscha
Copy link
Contributor Author

Thanks for the review! I merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants