Skip to content

[FLINK-13409][python] Supported java UDFs in python API.#9222

Closed
WeiZhong94 wants to merge 2 commits intoapache:masterfrom
WeiZhong94:FLINK-13409
Closed

[FLINK-13409][python] Supported java UDFs in python API.#9222
WeiZhong94 wants to merge 2 commits intoapache:masterfrom
WeiZhong94:FLINK-13409

Conversation

@WeiZhong94
Copy link
Contributor

What is the purpose of the change

This pull request aimed to support registering Java UDFs and using Java UDFs in Python Table API.

Brief change log

  • Add register_java_function() and list_user_defined_functions() in TableEnvironment class to support registering Java UDFs.
  • Add join_lateral() and left_outer_join_lateral() to support using UDTFs in python Table API.
  • *Fix incorrect documentation of joinLateral interfaces. *

Verifying this change

This change is already covered by existing tests, such as test_correlate.py and test_table_environment_api.py.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (python docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 25, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d69fada (Tue Aug 06 15:50:15 UTC 2019)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 25, 2019

CI report:

@dianfu
Copy link
Contributor

dianfu commented Jul 25, 2019

@WeiZhong94 Thanks a lot for the PR. It would be better to also update the docs.

@dianfu
Copy link
Contributor

dianfu commented Jul 25, 2019

The latest PR LGTM. +1 from my side.

@asfgit asfgit closed this in 366e916 Jul 25, 2019
asfgit pushed a commit that referenced this pull request Jul 25, 2019
wzhero1 pushed a commit to wzhero1/flink that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants