[FLINK-13241][Yarn/Mesos] Duplication of PR#9105 on master branch. #9246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed memory size into wrong configuration instance.
…otsPerWorker to compute tmCalculatedResourceProfile based on the RM altered configuration.
…at TMs are started with correct managed memory size.
…e of ResourceManager.
…S_MEMORY_MB in configuration.
… from ResourceManager.
…sk manager managed memory size YarnResourceManagerFactory#getResourceManagerConfiguration.
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit ced1ea2 (Tue Aug 06 15:54:14 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
…eateSlotsPerWorker to ResourceManagerTest#testCreateWorkerSlotProfiles, and update to verify slot profile calculation with determinate managed memory size.
xintongsong
force-pushed
the
master-FLINK-13241-rm-tm-managed-memory-inconsistent
branch
from
89ca6ef to
bc47897
Compare
…_RM_TASKS_MEMORY_MB in configuration." This reverts commit 50830e8.
…urceManagerFactory to ResourceManagerUtil.
xintongsong
force-pushed
the
master-FLINK-13241-rm-tm-managed-memory-inconsistent
branch
from
9ccfe40 to
ced1ea2
Compare
tillrohrmann
approved these changes
Jul 30, 2019
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for this forward port @xintongsong. LGTM. Merging.
xintongsong
deleted the
master-FLINK-13241-rm-tm-managed-memory-inconsistent
branch
wzhero1
pushed a commit
to wzhero1/flink
that referenced
this pull request
Aug 2, 2019
…ed memory size into wrong configuration instance. [FLINK-13241][yarn][test] Update YarnResourceManagerTest#testCreateSlotsPerWorker to compute tmCalculatedResourceProfile based on the RM altered configuration. [FLINK-13241][yarn][test] Update YarnConfigurationITCase to verify that TMs are started with correct managed memory size. [FLINK-13241][runtime] Calculating and set managed memory size outside of ResourceManager. [FLINK-13241][rumtime/yarn][test] Move YarnResourceManagerTest#testCreateSlotsPerWorker to ResourceManagerTest#testCreateWorkerSlotProfiles, and update to verify slot profile calculation with determinate managed memory size. [FLINK-13241][runtime] Move getResourceManagerConfiguration from ResourceManagerFactory to ResourceManagerUtil. This closes apache#9246.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a duplication of #9105 on master branch. The original PR #9105 was opened on release-1.9 branch.