Skip to content

Conversation

@ifndef-SleePy
Copy link
Contributor

What is the purpose of the change

  • Harden unstable case, JobMasterTest.testJobFailureWhenTaskExecutorHeartbeatTimeout

Brief change log

  • Enrich TestingHeartbeatServices, support manually trigger timeout for testing
  • Make JobMasterTest.testJobFailureWhenTaskExecutorHeartbeatTimeout not relying on timeout anymore
  • Correct invalid format of JobMasterTest

Verifying this change

  • This change is already covered by existing tests, such as JobMasterTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 29, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b3ee3de (Tue Aug 06 16:03:42 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❗ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 29, 2019

CI report:

@ifndef-SleePy
Copy link
Contributor Author

The Travis building fails due to a known unstable case, see https://issues.apache.org/jira/browse/FLINK-13242

@ifndef-SleePy
Copy link
Contributor Author

@flinkbot attention @tillrohrmann

@ifndef-SleePy
Copy link
Contributor Author

Bad luck. Travis building fails due to another unstable case, see https://issues.apache.org/jira/browse/FLINK-9900.
Will re-trigger Travis building.

@ifndef-SleePy ifndef-SleePy force-pushed the FLINK-12164 branch 2 times, most recently from f786c67 to ee88127 Compare August 1, 2019 09:40
@ifndef-SleePy
Copy link
Contributor Author

This PR overrides too much basic logic, I should re-implement it. Close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants