[FLINK-13535][kafka] do not abort transactions twice during KafkaProducer startup

[NicoK]

What is the purpose of the change

During startup of a transactional Kafka producer from previous state, we recover in two steps:

1. in TwoPhaseCommitSinkFunction, we commit pending commit-transactions and abort pending transactions and then call into finishRecoveringContext()
2. in FlinkKafkaProducer#finishRecoveringContext() we iterate over all recovered transaction IDs and abort them.

This may lead to some transactions being worked on twice and there is quite some overhead from creating a KafkaProducer for each of these transactions.

Brief change log

• provide finishRecoveringContext() with a collection of all transactions that TwoPhaseCommitSinkFunction already covered
• adapt FlinkKafkaProducer and FlinkKafkaProducer011 to ignores transactional IDs from that set

Verifying this change

This change is already covered by existing tests, such as FlinkKafkaProducerITCase and KafkaProducerExactlyOnceITCase.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): yes
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? JavaDocs

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8217764 (Tue Aug 06 15:56:31 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ✅ 1. The [description] looks good.
  • Approved by @becketqin
• ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • Approved by @becketqin
• ❓ 3. Needs [attention] from.
• ✅ 4. The change fits into the overall [architecture].
  • Approved by @becketqin
• ✅ 5. Overall code [quality] is good.
  • Approved by @becketqin

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 8217764 : FAILURE Build

[becketqin]

@NicoK Thanks for the patch. LGTM.

[becketqin]

@flinkbot approve all

[becketqin]

Merged to master.