-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-13688][hive] Limit the parallelism/memory of HiveCatalogUseBlinkITCase #9417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4df01ef (Fri Aug 23 10:18:58 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Another way is to extend |
|
And I'm not sure the root cause is the parallelism is too high for this case. We should support running very high parallelism batch job with only one slot by design. |
|
@KurtYoung Yeah, the main problem is memory request is too high(128MB). I think 8dacb85 will solve it. |
|
How about we use a pre configured mini cluster instead of lower the memory request? Because it's not 100% safe to just rely on lowering the sort memory, because we might choose hash aggregate. |
Yeah, that is a way too, but in this case, I think use lower memory is OK. Because the data is too few. |
|
I would like to repeat my first question: why not just extending |
OK. |
|
This case makes me feel that the first time a user uses blink batch sql, he has to think about resources..... |
|
+1 for fixing it. @KurtYoung @JingsongLi |
|
Verified locally, +1. |
What is the purpose of the change
limit the parallelism of HiveCatalogUseBlinkITCase to avoid too many slot requests by default parallelism (use the core size of machine).
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation