Skip to content

Conversation

@JingsongLi
Copy link
Contributor

What is the purpose of the change

substr is a common function, HIVE/SPARK/MYSQL/ORACLE/SQSERVER all support it. We should not delete it.
And tpc-h will generate the sql that contains substr. We should re-add it to fix e2e test failure.

Brief change log

Add substr in FlinkSqlOperatorTable, and add tests.

Verifying this change

ScalarFunctionsTest and SqlExpressionTest.
run the TPC-H E2E test.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@JingsongLi
Copy link
Contributor Author

JingsongLi commented Aug 13, 2019

I have successfully run the TPC-H E2E test on my local computer.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 13, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 59abb0f (Fri Aug 23 10:17:29 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 13, 2019

CI report:

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR @JingsongLi .

It seems The failed YARN case is not related to this issue.

Will merge this.

@asfgit asfgit closed this in 5a5966b Aug 14, 2019
asfgit pushed a commit that referenced this pull request Aug 14, 2019
…in blink planner to fix TPC-H e2e test failed

This closes #9427
@JingsongLi JingsongLi deleted the substr branch August 14, 2019 07:03
becketqin pushed a commit to becketqin/flink that referenced this pull request Aug 17, 2019
…in blink planner to fix TPC-H e2e test failed

This closes apache#9427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants