[FLINK-9900][tests] Harden ZooKeeperHighAvailabilityITCase

[ifndef-SleePy]

What is the purpose of the change

• Waiting checkpoint id increasing to 5 can not guarantee there must be a checkpoint with state data included. An empty checkpoint would fail the restoration checking.

Brief change log

• Use checkpointCompletedIncludingData to make sure we could start failing the job instead of checkpoint id increasing to 5

Verifying this change

• This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 72d9ea0 (Fri Aug 23 10:19:20 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 72d9ea0 : SUCCESS Build

[tillrohrmann]

Thanks for this fix @ifndef-SleePy. This test case seems to be very tricky. I think at some point we should rethink whether this test case shouldn't be retired. Too much maintenance effort went into it.

[ifndef-SleePy]

@tillrohrmann , thanks for reviewing.
I agree with you that it's a bit complicated. There are too many checking in once case. But it indeed found some bugs :)
After refactoring the CheckpointCoordinator, I will think about how to simplify it.