Skip to content

Conversation

@wuchong
Copy link
Member

@wuchong wuchong commented Aug 18, 2019

What is the purpose of the change

Fix builds for master branch are failed during compile stage.

Brief change log

  • flink-connector-elasticsearch doesn't exist at all. Fix the travis script to check flink-connector-elasticsearch6.

Verifying this change

This change is a trivial work without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 18, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 23a72b2 (Fri Aug 23 10:22:10 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 18, 2019

CI report:

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this problem so quickly @wuchong. LGTM. Merging.

Do you know why the build passed until a couple of days ago? I thought we removed the old elastic search connector quite some time ago and it should have failed right away. Maybe @zentol can help with that as well.

@wuchong wuchong deleted the fix-compile-build branch August 18, 2019 14:18
@wuchong
Copy link
Member Author

wuchong commented Aug 18, 2019

I have the same question. It should fail for a long time ago. Could this because of Travis caching mechanism?

@tillrohrmann
Copy link
Contributor

The reason why the build failed was indeed a cache inconsistency and not check_shaded_artifacts_connector_elasticsearch which checked for a non-existing connector directory. @zentol could it be that check_shaded_artifacts_connector_elasticsearch does not properly fail the build if it cannot find a directory?

@zentol
Copy link
Contributor

zentol commented Aug 21, 2019

Based on the JIRA error the check does fail if the directory or file doesn't exist.

I would conclude that the directory did exist, but as far as I can tell there shouldn't be a way for the cache to contain old date; Flink should always be compiled in a clean directory which is then cached separately from other builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants