Skip to content

[FLINK-13927] Add note about hadoop dependencies for local debug#9618

Merged
azagrebin merged 1 commit into
apache:masterfrom
azagrebin:FLINK-13927
Sep 5, 2019
Merged

[FLINK-13927] Add note about hadoop dependencies for local debug#9618
azagrebin merged 1 commit into
apache:masterfrom
azagrebin:FLINK-13927

Conversation

@azagrebin
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Currently if user tries to run the job locally (e.g. from IDE) and uses Hadoop fs, it will not work if hadoop dependencies are not on the class path which is the case for the example from the quick start.

Brief change log

We can add a hint about adding provided hadoop dependencies in this case (+ Idea hint about provided included checkbox in run/debug app setup) to docs/ops/deployment/hadoop.md.

Verifying this change

Run ./docs/build_docs.sh -i and open in browser to check the doc changes.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

@azagrebin azagrebin requested review from aljoscha and zentol September 4, 2019 16:01
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Sep 4, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3c991dc (Wed Oct 16 08:13:08 UTC 2019)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Sep 4, 2019

CI report:

Copy link
Copy Markdown
Contributor

@aljoscha aljoscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@azagrebin
Copy link
Copy Markdown
Contributor Author

Thanks for the review @aljoscha
merged into master by 3c991dc

@azagrebin azagrebin closed this Sep 5, 2019
@azagrebin azagrebin merged commit 3c991dc into apache:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants