Skip to content

[FLINK-13960] Add throwing HighAvailabilityServices#getWebMonitorLeaderRetriever default impl#9629

Closed
tillrohrmann wants to merge 2 commits intoapache:masterfrom
tillrohrmann:FLINK-13960
Closed

[FLINK-13960] Add throwing HighAvailabilityServices#getWebMonitorLeaderRetriever default impl#9629
tillrohrmann wants to merge 2 commits intoapache:masterfrom
tillrohrmann:FLINK-13960

Conversation

@tillrohrmann
Copy link
Copy Markdown
Contributor

@tillrohrmann tillrohrmann commented Sep 5, 2019

What is the purpose of the change

Default impl HighAvailabilitySerivces.getWebMonitorLeaderRetriever throws exception referring to implement the ClientHighAvailabilityServices instead.

cc @tisonkun

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

…erRetriever default impl

Default impl HighAvailabilitySerivces.getWebMonitorLeaderRetriever throws exception
in order to refer to implementing the CLientHighAvailabilityServices instead.
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Sep 5, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7ef0929 (Fri Sep 06 09:12:10 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

To be clear, as discussed in FLINK-13964 we might introduce a getRestEndpointRetriever in HighAvailabilityServices with inheriting ClientHighAvailabilityServices whose default implementation is delegate to getWebMonitorLeaderRetriever. Is it correct?

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Sep 5, 2019

CI report:

@tillrohrmann
Copy link
Copy Markdown
Contributor Author

Yes this is correct. Thanks for your review @tisonkun.

@tillrohrmann
Copy link
Copy Markdown
Contributor Author

Thanks for the review @tisonkun. Merging this PR.

@tillrohrmann tillrohrmann deleted the FLINK-13960 branch September 6, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants