[FLINK-13960] Add throwing HighAvailabilityServices#getWebMonitorLeaderRetriever default impl#9629
[FLINK-13960] Add throwing HighAvailabilityServices#getWebMonitorLeaderRetriever default impl#9629tillrohrmann wants to merge 2 commits intoapache:masterfrom
Conversation
…erRetriever default impl Default impl HighAvailabilitySerivces.getWebMonitorLeaderRetriever throws exception in order to refer to implementing the CLientHighAvailabilityServices instead.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7ef0929 (Fri Sep 06 09:12:10 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
LGTM +1
To be clear, as discussed in FLINK-13964 we might introduce a getRestEndpointRetriever in HighAvailabilityServices with inheriting ClientHighAvailabilityServices whose default implementation is delegate to getWebMonitorLeaderRetriever. Is it correct?
|
Yes this is correct. Thanks for your review @tisonkun. |
|
Thanks for the review @tisonkun. Merging this PR. |
What is the purpose of the change
Default impl
HighAvailabilitySerivces.getWebMonitorLeaderRetrieverthrows exception referring to implement the ClientHighAvailabilityServices instead.cc @tisonkun
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation