[FLINK-2465] Fix SocketClientSink closeConnection function memory leak #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Merging this... |
Contributor
|
BTW: All of these things are not memory leaks. Java always closes the streams when the objects are garbage collected. It is simply good practice to close them as early as possible. |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Aug 3, 2015
Contributor
|
@StephanEwen |
Contributor
|
Agreed, it is good to fix these things, that's why I merge them. |
nikste
pushed a commit
to nikste/flink
that referenced
this pull request
Sep 29, 2015
nltran
pushed a commit
to nltran/flink
that referenced
this pull request
Jan 8, 2016
pnowojski
pushed a commit
that referenced
this pull request
Jul 3, 2024
[MATRIX-213] Min max scalar function Implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closeConnection, should call dataOutputStream.close() instead of dataOutputStream.flush() because close() will call flush() first and then releases any system resources associated with this stream. Only call dataOutputStream.flush() cause memory leak.