Skip to content

Conversation

@Jiayi-Liao
Copy link
Contributor

What is the purpose of the change

Fix unit test: KafkaProducerTestBase.testOneToOneAtLeastOnceRegularSink

Brief change log

Add retries and acks config to reduce the risk of failure of flush() method.

Verifying this change

Unit Testing.

Does this pull request potentially affect one of the following parts:

Documentation

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 3, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1226ddc (Wed Oct 16 08:39:28 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 3, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@Jiayi-Liao
Copy link
Contributor Author

Remove the retries config in exactlyOnce testing because exactly-once producer sets it internally.

@flinkbot run travis

@Jiayi-Liao
Copy link
Contributor Author

@flinkbot run travis

@becketqin
Copy link
Contributor

@flinkbot approve all

Copy link
Contributor

@becketqin becketqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. LGTM.

@becketqin becketqin merged commit d963eab into apache:master Oct 10, 2019
@Jiayi-Liao Jiayi-Liao deleted the FLINK-14309-producer branch October 11, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants