[FLINK-14130][client] Remove ClusterClient.run() methods

[tisonkun]

What is the purpose of the change

Remove legacy run method in ClusterClient. This is part of effort towards a ClusterClient interface.

The following works contain make operations async and then we can remove lastJobExecutionResult and detachedJobSubmission, let them env configuration and taken care of by FLIP-73. Also shift down flinkConfig.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[tisonkun]

never be null

[aljoscha]

What happens if the user program main() doesn't call execute? Could it then be null?

[tisonkun]

see my comment below. We can always do the null check but it is redundant.

[tisonkun]

to exclude detach configuration from ClusterClient, it would be later temporary move as a parameter of this method. This method is a temporary workaround to finish the job done by ContextEnvironment. I think FLIP-73 would properly handle it.

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c17fdce (Fri Oct 18 09:12:03 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• c17fdce : SUCCESS Build

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build

[aljoscha]

This looks good! I had one comment, once that is resolved I can merge this.

And yes, the future work should move lastJobExecutionResult, maybe to ContextEnvironment, and also remove the "detached" flag from the client.

[aljoscha]

Merged! ☕️

[tisonkun]

Thanks for your review and help @aljoscha !