Skip to content

Conversation

@AT-Fieldless
Copy link
Contributor

What is the purpose of the change

Current NettyConfig's port check is from 0 to 65536, and this pull request change it to 0 to 65535.

Brief change log

  • *change Flink's port check to 0 to 65535

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (don't know)
  • The runtime per-record code paths (performance sensitive): (don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@AT-Fieldless AT-Fieldless changed the title change Flink's port check to 0 to 65535 [FLINK-14481][RunTime/Network]change Flink's port check to 0 to 65535 Oct 25, 2019
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 25, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c63d8e2 (Wed Dec 04 15:02:30 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 25, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@StephanEwen
Copy link
Contributor

Looks correct, thanks for fixing this.

Merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Nov 7, 2019
@asfgit asfgit closed this in 0b33726 Nov 8, 2019
@AT-Fieldless AT-Fieldless deleted the FLINK-14481 branch November 8, 2019 08:38
@AT-Fieldless AT-Fieldless restored the FLINK-14481 branch November 11, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants