Skip to content

parse_ipc_message should return exception instead of return None if parse failed #72

@zhaohaidao

Description

@zhaohaidao

Search before asking

  • I searched in the issues and found nothing similar.

Description

Followup From: #57
IIUC, if data.len() < 8 { , continuation != CONTINUATION_MARKER, if data.len() < 8 + metadata_size should all be unexpected, right?
I think we should return exception instead of return None.

You can do return exception in this pr or another pr(but rememeber to left todo).

Willingness to contribute

  • I'm willing to submit a PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions