[feat] Add examples and stub files for Python bindings #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naivedogger
changed the title
naivedogger
force-pushed
the
pr/examples-and-stub-files
branch
from
1a42e61 to
90c14a4
Compare
luoyuxia
reviewed
Oct 17, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@naivedogger Thanks for the pr. Left some comments. PTAL
Contributor
There was a problem hiding this comment.
should put it to bindings/python/fluss?
| class FlussTable: | ||
| async def new_append_writer(self) -> AppendWriter: ... | ||
| def new_log_scanner(self) -> LogScanner: ... | ||
| def new_log_scanner_sync(self) -> LogScanner: ... |
| class TablePath: | ||
| def __init__(self, database: str, table: str) -> None: ... | ||
| def database(self) -> str: ... | ||
| def table(self) -> str: ... |
Contributor
There was a problem hiding this comment.
also add __hash__ and __eq__
Contributor
|
update |
Contributor
Author
|
@luoyuxia, thanks for your kind code review. I have addressed the comments and revised the stub file. PTAL. |
luoyuxia
force-pushed
the
pr/examples-and-stub-files
branch
from
1092f2f to
1cf0a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #16
Brief change log
Tests
API and Format
Documentation