chore: add integration tests for subscribe_batch and project_by_name #116
Conversation
|
Good morning and thanks for running the workflows! i updated the assertion to Note: clippy is pointing many more warnings in other tests, while this is still fine, its something that should be examinated in the future |
| assert!((1..=6).contains(&id), "id should be between 1 and 6"); | ||
| assert!( | ||
| ["a", "b", "c", "d", "e", "f"].contains(&value), | ||
| "value should be one of a-f" | ||
| ); |
There was a problem hiding this comment.
Should we check the ordering of the records?
There was a problem hiding this comment.
Agree
good catch, thank you
|
|
||
| let records: Vec<_> = scan_records.into_iter().collect(); | ||
| let mut records: Vec<_> = scan_records.into_iter().collect(); | ||
| records.sort_by_key(|r| r.offset()); |
There was a problem hiding this comment.
Curious, is this sort_by_key needed? What happens if you do not sort?
My assumption is that poll_batch should already return records ordered by offset.
|
The This follows the existing pattern in the codebase:
|
You're right. Java side uses inAnyOrder assertion: https://github.com/apache/fluss/blob/bcebe7f48dde96f7085bf14af41ff18afc1f99e6/fluss-client/src/test/java/org/apache/fluss/client/table/scanner/log/RemoteLogScannerITCase.java#L114 Approving! |
Kudos Mr.Lee ! |
Add two new integration tests to improve API coverage: - test_subscribe_batch: tests LogScanner::subscribe_batch() with HashMap - test_project_by_name: tests TableScan::project_by_name() with column names Both tests include error case validation.
sort records by offset and verify exact ordering.
luoyuxia
force-pushed
the
add-integration-tests-subscribe-batch-project-by-name
branch
from
7e8c046 to
2774867
Compare
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@AndreaBozzo Thanks for the pr. LGTM! I only append a small commit to improve test.
Thanks @luoyuxia , looking forward to further help on this promising project, take care ! |
AndreaBozzo
deleted the
add-integration-tests-subscribe-batch-project-by-name
branch
Cool! Look forward to it. |
3 participants
test_subscribe_batch: testsLogScanner::subscribe_batch()with HashMaptest_project_by_name: testsTableScan::project_by_name()with column namesLinked issue: #31