feat: introduce database level ops for cpp bindings#286
Merged
luoyuxia merged 2 commits intoapache:mainfrom Feb 8, 2026
Merged
feat: introduce database level ops for cpp bindings#286luoyuxia merged 2 commits intoapache:mainfrom
luoyuxia merged 2 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds database-level administrative operations to the C++ bindings, aligning the C++ Admin API with the underlying Rust FlussAdmin capabilities requested in issue #274.
Changes:
- Extended the Rust CXX bridge with database structs/results and added Admin FFI methods (create/drop/list DBs, existence checks, info lookup, list tables, drop partition).
- Added Rust/C++ conversion helpers for
DatabaseDescriptorandDatabaseInfo. - Exposed new C++
AdminAPIs in the public header and provided a newadmin_example.cppplus build targets (CMake + Bazel).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| bindings/cpp/src/types.rs | Adds conversions between FFI and core database metadata types. |
| bindings/cpp/src/lib.rs | Extends the CXX bridge and implements new Admin database/partition operations. |
| bindings/cpp/src/ffi_converter.hpp | Adds C++ ↔ FFI converters for database descriptor/info. |
| bindings/cpp/src/admin.cpp | Adds C++ Admin wrapper methods for new database ops and drop_partition. |
| bindings/cpp/include/fluss.hpp | Exposes DatabaseDescriptor, DatabaseInfo, and new Admin methods in the public C++ API. |
| bindings/cpp/examples/admin_example.cpp | New example demonstrating database + table admin operations. |
| bindings/cpp/CMakeLists.txt | Adds a CMake target for the new admin example binary. |
| bindings/cpp/BUILD.bazel | Adds a Bazel target for the new admin example binary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@fresh-borzoni @zhaohaidao Could you please help review? |
fresh-borzoni
approved these changes
Feb 8, 2026
Contributor
fresh-borzoni
left a comment
There was a problem hiding this comment.
@luoyuxia TY for the PR.
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #274
Brief change log
Tests
API and Format
Documentation