Fix issue where FixedSizedBinary type cannot be build in arrow#304
Merged
luoyuxia merged 3 commits intoapache:mainfrom Feb 13, 2026
Merged
Fix issue where FixedSizedBinary type cannot be build in arrow#304luoyuxia merged 3 commits intoapache:mainfrom
luoyuxia merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@luoyuxia @fresh-borzoni Appreciate a review here |
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@leekeiabstraction Ty for the PR. LGTM overall, left some comments.
PTAL
luoyuxia
reviewed
Feb 13, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thanks for the pr. Left minor comments. PTAL
Contributor
Author
|
Thank you for the reviews. Addressed comments, PTAL! |
fresh-borzoni
approved these changes
Feb 13, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@leekeiabstraction Ty, LGTM.
luoyuxia
approved these changes
Feb 13, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@leekeiabstraction Thanks. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix bug where use of
DataTypes::binary(a)fails as Arrow's FixedSizedBinaryBuilder is not used causing data write error.Tests
Updated IT