feat: allow propagating hostname as raw bootstrap address#307
Merged
luoyuxia merged 5 commits intoapache:mainfrom Feb 14, 2026
Merged
feat: allow propagating hostname as raw bootstrap address#307luoyuxia merged 5 commits intoapache:mainfrom
luoyuxia merged 5 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables the Fluss Rust client to accept hostnames (in addition to IP addresses) as bootstrap server addresses by introducing DNS resolution capability. Previously, the client only supported raw IP addresses in host:port format.
Changes:
- Refactored bootstrap address parsing to support DNS hostname resolution
- Extracted parsing logic into a dedicated
parse_bootstrapmethod - Added unit tests for the new hostname resolution functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
updated |
Contributor
|
@zuston But ci fails. Please take a look |
Contributor
|
I'll help fix ci |
Member
Author
tks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Brief change log
Tests
API and Format
Documentation