Skip to content

feat: allow propagating hostname as raw bootstrap address#307

Merged
luoyuxia merged 5 commits intoapache:mainfrom
zuston:hostname
Feb 14, 2026
Merged

feat: allow propagating hostname as raw bootstrap address#307
luoyuxia merged 5 commits intoapache:mainfrom
zuston:hostname

Conversation

@zuston
Copy link
Member

@zuston zuston commented Feb 13, 2026

Purpose

Linked issue: close #xxx

Brief change log

Tests

API and Format

Documentation

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the Fluss Rust client to accept hostnames (in addition to IP addresses) as bootstrap server addresses by introducing DNS resolution capability. Previously, the client only supported raw IP addresses in host:port format.

Changes:

  • Refactored bootstrap address parsing to support DNS hostname resolution
  • Extracted parsing logic into a dedicated parse_bootstrap method
  • Added unit tests for the new hostname resolution functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuston Thanks. LGTM! But take care the comments by copilot.

zuston and others added 2 commits February 13, 2026 17:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@zuston
Copy link
Member Author

zuston commented Feb 13, 2026

@zuston Thanks. LGTM! But take care the comments by copilot.

updated

@luoyuxia
Copy link
Contributor

@zuston But ci fails. Please take a look

@luoyuxia
Copy link
Contributor

I'll help fix ci

@luoyuxia luoyuxia merged commit fdfde8d into apache:main Feb 14, 2026
13 checks passed
@zuston
Copy link
Member Author

zuston commented Feb 14, 2026

I'll help fix ci

tks!

@zuston zuston deleted the hostname branch February 14, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants