Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive unit tests for DataType validation edge cases and RowType projection functionality, addressing issue #309. The changes introduce test coverage for precision/scale validation in DecimalType, TimeType, and TimestampType, as well as tests for RowType field projection operations.
Changes:
- Added
is_nullable()methods to DecimalType, TimeType, TimestampType, and TimestampLTzType - Added unit tests for DecimalType validation covering valid and invalid precision/scale combinations
- Added unit tests for TimeType and TimestampType valid precision ranges (0-9)
- Added unit tests for RowType projection by indices and field names, including error cases
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
reviewed
Feb 13, 2026
|
|
||
| // Mixed existing and non-existing: only existing fields are projected | ||
| let projected = row_type | ||
| .project_with_field_names(&["id".to_string(), "nonexistent".to_string()]) |
Contributor
There was a problem hiding this comment.
I'd argue it should throw exceptioin when the field doesn't exist just like java side. Could you please help fix it?
Author
Fixed the formatting which caused the ci to fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #309
Brief change log
Add unit tests for DataType validation edge cases and RowType projection
Tests