-
Notifications
You must be signed in to change notification settings - Fork 488
Open
Copy link
Description
Search before asking
- I searched in the issues and found nothing similar.
Motivation
RocksDB statistics collection has performance overhead. Users should be able to disable it when:
- RocksDB-level metrics are not needed
- Running in resource-constrained environments
- Troubleshooting performance issues
Solution
New Configuration
| Option | Type | Default | Description |
|---|---|---|---|
kv.rocksdb.statistics.enabled |
Boolean | false | Enable RocksDB statistics collection for metrics |
Files Modified
ConfigOptions.java- Add new config optionKvTablet.java- Read config to control statistics initializationRocksDBStatistics.java- Minor optimization: usegetLongProperty()instead ofgetProperty()to reduce JNI memory overheadconfiguration.md- Documentation
Anything else?
Additional Optimization:
Replaced RocksDB.getProperty() with getLongProperty() in statistics collection to avoid unnecessary string allocation in JNI layer during high-frequency Prometheus scraping.
Willingness to contribute
- I'm willing to submit a PR!
Metadata
Metadata
Assignees
Labels
No labels