[lake/lance] Throw exception for create primary key table when datalake.format = lance #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naivedogger
changed the title
xx789633
reviewed
Aug 11, 2025
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorService.java
Outdated
Show resolved
Hide resolved
Contributor
|
Looks good to me. @luoyuxia would you like to take a look at this pr? |
luoyuxia
reviewed
Aug 12, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@naivedogger Thanks for the pr. Left some comments.
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorService.java
Outdated
Show resolved
Hide resolved
...luss-lake-lance/src/test/java/com/alibaba/fluss/lake/lance/LakeEnabledTableCreateITCase.java
Outdated
Show resolved
Hide resolved
luoyuxia
changed the title
Contributor
Author
|
Thanks @luoyuxia for the review. Comments have been resolved. |
leonardBang
approved these changes
Aug 12, 2025
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @naivedogger for the contribution, LGTM
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
…ke.format = lance (apache#1444)
polyzos
pushed a commit
to Alibaba-HZY/fluss
that referenced
this pull request
Aug 31, 2025
…ke.format = lance (apache#1444)
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Sep 21, 2025
…ke.format = lance (apache#1444)
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Sep 21, 2025
…ke.format = lance (apache#1444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1160
Because currently we only supports tiering log tables into lance, we have to make sure this is configured correctly when creating a table. This PR throws InvalidTableException when the user is trying to activate tiering service for a primary key table.
Brief change log
Tests
fluss-lake/fluss-lake-lance/src/test/java/com/alibaba/fluss/lake/lance/LakeEnabledTableCreateITCase.java
API and Format
Documentation