Skip to content

[lake/lance] Throw exception for create primary key table when datalake.format = lance #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2025
Merged

[lake/lance] Throw exception for create primary key table when datalake.format = lance #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e70de74
solve
naivedogger Jul 31, 2025
c2179f2
fix format
naivedogger Aug 1, 2025
7de3dc4
address comments
naivedogger Aug 11, 2025
5eac302
adress comments
naivedogger Aug 12, 2025
a3f54eb
rerun CI
naivedogger Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions fluss-lake/fluss-lake-lance/src/main/java/com/alibaba/fluss/lake/lance/LanceLakeCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package com.alibaba.fluss.lake.lance;

import com.alibaba.fluss.config.Configuration;
import com.alibaba.fluss.exception.InvalidTableException;
import com.alibaba.fluss.lake.lakestorage.LakeCatalog;
import com.alibaba.fluss.lake.lance.utils.LanceArrowUtils;
import com.alibaba.fluss.lake.lance.utils.LanceDatasetAdapter;
Expand Down Expand Up @@ -58,6 +59,12 @@ public LanceLakeCatalog(Configuration config) {

@Override
public void createTable(TablePath tablePath, TableDescriptor tableDescriptor) {
// currently, we don't support primary key table for lance
if (tableDescriptor.hasPrimaryKey()) {
throw new InvalidTableException(
"Currently, we don't support tiering a primary key table to Lance");
}

LanceConfig config =
LanceConfig.from(
options.toMap(), tablePath.getDatabaseName(), tablePath.getTableName());
Expand Down
22 changes: 22 additions & 0 deletions ...s-lake-lance/src/test/java/com/alibaba/fluss/lake/lance/LakeEnabledTableCreateITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.alibaba.fluss.config.ConfigOptions;
import com.alibaba.fluss.config.Configuration;
import com.alibaba.fluss.exception.FlussRuntimeException;
import com.alibaba.fluss.exception.InvalidTableException;
import com.alibaba.fluss.lake.lance.utils.LanceDatasetAdapter;
import com.alibaba.fluss.metadata.DataLakeFormat;
import com.alibaba.fluss.metadata.Schema;
Expand All @@ -49,6 +50,7 @@
import static com.alibaba.fluss.metadata.TableDescriptor.OFFSET_COLUMN_NAME;
import static com.alibaba.fluss.metadata.TableDescriptor.TIMESTAMP_COLUMN_NAME;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

/** ITCase for create lake enabled table with lance as lake storage. */
class LakeEnabledTableCreateITCase {
Expand Down Expand Up @@ -201,4 +203,24 @@ void testLogTable() throws Exception {
logC18, logC19));
assertThat(expectedSchema).isEqualTo(LanceDatasetAdapter.getSchema(config).get());
}

@Test
void testPrimaryKeyTable() throws Exception {
TableDescriptor pkTable =
TableDescriptor.builder()
.schema(
Schema.newBuilder()
.column("pk_c1", DataTypes.INT())
.column("pk_c2", DataTypes.STRING())
.primaryKey("pk_c1")
.build())
.distributedBy(BUCKET_NUM)
.property(ConfigOptions.TABLE_DATALAKE_ENABLED, true)
.build();
TablePath pkTablePath = TablePath.of(DATABASE, "pk_table");
assertThatThrownBy(() -> admin.createTable(pkTablePath, pkTable, false).get())
.cause()
.isInstanceOf(InvalidTableException.class)
.hasMessage("Currently, we don't support tiering a primary key table to Lance");
}
}