[client] Indexed row support projection#151
Merged
Merged
Conversation
swuferhong
force-pushed
the
indexed-row-support-projection
branch
11 times, most recently
from
0bf5a76 to
9188502
Compare
wuchong
requested changes
Dec 23, 2024
swuferhong
force-pushed
the
indexed-row-support-projection
branch
from
9188502 to
04ed220
Compare
Contributor
Author
Done! comments all addressed. Pr ready. |
Contributor
Author
|
@wuchong Comments addressed. CI passed |
This simplifies code and reduce CPU costs as well.
wuchong
force-pushed
the
indexed-row-support-projection
branch
from
04ed220 to
55e7bb9
Compare
Member
|
@swuferhong I refactored the code and only project the row once to reduce CPU costs. Please have a look. |
Contributor
Author
LGTM +1 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #150
Even if Fluss only support projection push down to server for log format as ARROW. However, INDEXED format also need to support projection push down in client side. This pr is aims to fix this bug.
Tests
API and Format
Documentation