Skip to content

[build] Add Maven Wrapper#162

Merged
wuchong merged 2 commits into
apache:mainfrom
michaelkoepf:feature/maven-wrapper
Feb 24, 2025
Merged

[build] Add Maven Wrapper#162
wuchong merged 2 commits into
apache:mainfrom
michaelkoepf:feature/maven-wrapper

Conversation

@michaelkoepf
Copy link
Copy Markdown
Contributor

@michaelkoepf michaelkoepf commented Dec 12, 2024

Purpose

Linked issue: close #161

Add Maven Wrapper to project.

Tests

n/a

API and Format

n/a

Documentation

n/a

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

@michaelkoepf michaelkoepf changed the title [improve][feature] Add Maven Wrapper [build][feature] Add Maven Wrapper Dec 14, 2024
@michaelkoepf michaelkoepf changed the title [build][feature] Add Maven Wrapper [build] Add Maven Wrapper Dec 27, 2024
Copy link
Copy Markdown
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelkoepf for the contribution. I left some comments and could you rebase the branch to resolve conflicts?

Comment thread .mvn/wrapper/maven-wrapper.properties Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread website/docs/dev/building.md Outdated
Comment thread website/docs/dev/ide-setup.md Outdated
- Added compatible Maven Wrapper version to project
- Updated all maven commands

Issue apache#161
@michaelkoepf
Copy link
Copy Markdown
Contributor Author

@wuchong addressed feedback and rebased, ptal

Copy link
Copy Markdown
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit f982db0 into apache:main Feb 24, 2025
@michaelkoepf michaelkoepf deleted the feature/maven-wrapper branch February 24, 2025 09:01
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add a Maven Wrapper to the project

3 participants