-
Notifications
You must be signed in to change notification settings - Fork 492
[helm] Add tabletServer.count configuration option
#2456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
affo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, suggesting a more general way of treating tablet server's conf
helm/values.yaml
Outdated
| storageClass: | ||
|
|
||
| # Tablet server only configuration options | ||
| tabletServer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, it looks to me that persistence is also a tablet server configuration.
Wouldn't it be better to have:
tablet:
numberOfReplicas:
storage:
enabled:
size:
class:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swuferhong what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what means 'persistence' for fluss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @swuferhong,
In the tablet and coordinator servers we have option to enabled and attach persistent volume (PV), so that the storage is not transient when they are recreated.
For example, for tablet: https://github.com/morazow/fluss/blob/main/helm/templates/sts-tablet.yaml#L99-L109
This could be enabled for data volumes.
I agree with @affo, we should maybe separate these configurations per type since sizes and storage classes could be different for coordinator and tablet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swuferhong persistence is the current key in values.yaml:
persistence:
enabled: false
size: 1Gi
storageClass:
And it is a top-level key.
What I am suggesting here is to group multiple tablet-relevant configs under tablet.
In any case we would need:
tablet:
numberOfReplicas:
coordinator:
numberOfReplicas: # for HA
At this point, we may extend tablet to include the current persistence values.
Does this make sense to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with numberOfReplicas suggestion, let's wait for @swuferhong input for moving persistence to each tablet & coordinator sections 🤝
|
This looks like a flakey test: https://github.com/apache/fluss/actions/runs/21281906620/job/61447896522?pr=2456 |
swuferhong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Linked issue: close #2455
Brief change log
Enable setting the number tablet servers when deploying with helm charts.
Tests
API and Format
Documentation
Added parameter section in the helm deployment documentation.