Skip to content

Conversation

@morazow
Copy link
Contributor

@morazow morazow commented Jan 23, 2026

Purpose

Linked issue: close #2455

Brief change log

Enable setting the number tablet servers when deploying with helm charts.

Tests

API and Format

Documentation

Added parameter section in the helm deployment documentation.

Copy link

@affo affo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, suggesting a more general way of treating tablet server's conf

helm/values.yaml Outdated
storageClass:

# Tablet server only configuration options
tabletServer:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, it looks to me that persistence is also a tablet server configuration.

Wouldn't it be better to have:

tablet:
  numberOfReplicas:
  storage:
    enabled:
    size:
    class:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swuferhong what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what means 'persistence' for fluss?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @swuferhong,

In the tablet and coordinator servers we have option to enabled and attach persistent volume (PV), so that the storage is not transient when they are recreated.

For example, for tablet: https://github.com/morazow/fluss/blob/main/helm/templates/sts-tablet.yaml#L99-L109

This could be enabled for data volumes.

I agree with @affo, we should maybe separate these configurations per type since sizes and storage classes could be different for coordinator and tablet.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swuferhong persistence is the current key in values.yaml:

persistence:
  enabled: false
  size: 1Gi
  storageClass:

And it is a top-level key.

What I am suggesting here is to group multiple tablet-relevant configs under tablet.
In any case we would need:

tablet:
  numberOfReplicas:

coordinator:
  numberOfReplicas: # for HA

At this point, we may extend tablet to include the current persistence values.
Does this make sense to you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with numberOfReplicas suggestion, let's wait for @swuferhong input for moving persistence to each tablet & coordinator sections 🤝

@affo
Copy link

affo commented Jan 28, 2026

Copy link
Contributor

@swuferhong swuferhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[helm] Add tablet server count to helm charts

3 participants